Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 23112017: Update more test for assignment to final variables (Closed)

Created:
7 years, 4 months ago by Søren Gjesse
Modified:
7 years, 4 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Update more test for assignment to final variables This is a follow-up to https://code.google.com/p/dart/source/detail?r=26519, as there where more tests checking assignments to final variables. Changed the negative tests to multi-tests for running with the analyzer(s). The latest spec (0.51) says: Attempting to assign to a final variable anywhere except in its declaration or in a constructor header will cause a runtime error to be thrown as discussed below. The assignment will also give rise to a static warning. R=ricow@google.com BUG=7062, 11591, 12184 Committed: https://code.google.com/p/dart/source/detail?r=26583

Patch Set 1 #

Patch Set 2 : Add new multi-test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -44 lines) Patch
M tests/language/final_for_in_variable_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/final_param_negative_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
A + tests/language/final_param_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/language/language_analyzer.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/language/static_final_field2_negative_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
A + tests/language/static_final_field2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 4 months ago (2013-08-22 13:48:20 UTC) #1
Søren Gjesse
On 2013/08/22 13:48:20, Søren Gjesse wrote: Ping
7 years, 4 months ago (2013-08-23 07:02:55 UTC) #2
Søren Gjesse
Rico could you please take a look?
7 years, 4 months ago (2013-08-23 07:21:55 UTC) #3
ricow1
LGTM
7 years, 4 months ago (2013-08-23 07:32:37 UTC) #4
Søren Gjesse
7 years, 4 months ago (2013-08-23 08:15:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r26583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698