Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 23103010: Add issue numbers to language tests status files (Closed)

Created:
7 years, 4 months ago by Søren Gjesse
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add issue numbers to language tests status files Moved VM specific tests to a separate directory R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26596

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added more issue numbers #

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1392 lines) Patch
D tests/language/allocation_sinking_vm_test.dart View 1 chunk +0 lines, -189 lines 0 comments Download
D tests/language/deopt_hoisted_smi_check_vm_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/language/if_conversion_vm_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D tests/language/issue11087_vm_test.dart View 1 chunk +0 lines, -23 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 4 chunks +42 lines, -42 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 3 chunks +21 lines, -21 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 2 chunks +22 lines, -24 lines 0 comments Download
D tests/language/load_to_load_forwarding_vm_test.dart View 1 chunk +0 lines, -243 lines 0 comments Download
D tests/language/math_vm_test.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D tests/language/no_such_method_error_message_vm_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/language/null_hashcode_optimized_vm_test.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/language/store_to_load_forwarding_phis_vm_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/language/type_cast_vm_test.dart View 1 chunk +0 lines, -137 lines 0 comments Download
D tests/language/type_vm_test.dart View 1 chunk +0 lines, -441 lines 0 comments Download
A + tests/language/vm/allocation_sinking_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/deopt_hoisted_smi_check_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/if_conversion_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/issue11087_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/load_to_load_forwarding_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/math_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/no_such_method_error_message_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/null_hashcode_optimized_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/store_to_load_forwarding_phis_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/type_cast_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/language/vm/type_vm_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
7 years, 4 months ago (2013-08-23 11:08:46 UTC) #1
kustermann
LGTM with comment https://codereview.chromium.org/23103010/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/23103010/diff/1/tests/language/language_dart2js.status#newcode78 tests/language/language_dart2js.status:78: built_in_identifier_prefix_test: Issue 6972 This is not ...
7 years, 4 months ago (2013-08-23 11:15:39 UTC) #2
kustermann
[+iposva] @Ivan: It seems to me a bit strange that we have 'allocation_sinking_vm_test.dart' etc. under ...
7 years, 4 months ago (2013-08-23 11:19:40 UTC) #3
Søren Gjesse
https://codereview.chromium.org/23103010/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/23103010/diff/1/tests/language/language_dart2js.status#newcode78 tests/language/language_dart2js.status:78: built_in_identifier_prefix_test: Issue 6972 On 2013/08/23 11:15:39, kustermann wrote: > ...
7 years, 4 months ago (2013-08-23 11:30:17 UTC) #4
Søren Gjesse
7 years, 4 months ago (2013-08-23 11:32:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r26596 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698