Issue 23102019: Evaluate expression in the context of a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23102019: Evaluate expression in the context of a class (Closed)

Created:
7 years, 4 months ago by hausner

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Evaluate expression in the context of a class Allows debugger to evaluate an expression in the context of a static method of a class. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26617

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -38 lines)			Patch
M	runtime/bin/dbg_message.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	3 chunks	+26 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+3 lines, -0 lines	2 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+49 lines, -24 lines	0 comments	Download
M	tools/ddbg.dart	View	6 chunks	+26 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/23102019/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/23102019/diff/1/runtime/vm/object.h#newcode952 runtime/vm/object.h:952: Only one line between functions.

7 years, 4 months ago (2013-08-23 22:26:10 UTC) #2

hausner

Committed patchset #1 manually as r26617 (presubmit successful).

7 years, 4 months ago (2013-08-23 22:42:47 UTC) #3

hausner

7 years, 4 months ago (2013-08-23 22:44:50 UTC) #4

Message was sent while issue was closed.

Thank you

https://codereview.chromium.org/23102019/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23102019/diff/1/runtime/vm/object.h#newcode952
runtime/vm/object.h:952: 
On 2013/08/23 22:26:10, srdjan wrote:
> Only one line between functions.

Done.

Expand Messages | Collapse Messages