Issue 23094003: Make sure type information is not lost in snapshots created in production mode,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23094003: Make sure type information is not lost in snapshots created in production mode, (Closed)

Created:
7 years, 4 months ago by regis

Modified:
7 years, 4 months ago

Reviewers:
hausner, siva, Ivan Posva

CC:
reviews_dartlang.org, Ivan Posva, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Make sure type information is not lost in snapshots created in production mode, since they can be executed in checked mode. Add snapshot test. R=hausner@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26127

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -33 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	2 chunks	+38 lines, -14 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	3 chunks	+17 lines, -19 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1	3 chunks	+109 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

hausner

LGTM2, and thank you for the updated comments in the code.

7 years, 4 months ago (2013-08-14 15:01:56 UTC) #3

regis

7 years, 4 months ago (2013-08-14 15:52:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r26127 (presubmit successful).