Improve DartDocs for dart:core classes that may not be extended or implemented.

Improve DartDocs for dart:core classes that may not be extended or implemented.

R=ahe@google.com, gbracha@google.com, kathyw@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26216

[gbracha, 2013-08-15 19:57:06]

lgtm

[ahe, 2013-08-15 20:02:54]

I like the improved documentation, but something smells wrong about
bool.toString having an implementation.

https://codereview.chromium.org/23087004/diff/3001/sdk/lib/core/bool.dart
File sdk/lib/core/bool.dart (right):

https://codereview.chromium.org/23087004/diff/3001/sdk/lib/core/bool.dart#new...
sdk/lib/core/bool.dart:21: * Returns [:"true":] if the receiver is [:true:], or
[:"false":] if the
I'm not sure I like adding this method. dart2js only uses this class for an
interface, and you cannot change this method without changing implementation
details in dart2js.

[rmacnak, 2013-08-15 20:14:11]

https://codereview.chromium.org/23087004/diff/3001/sdk/lib/core/bool.dart
File sdk/lib/core/bool.dart (right):

https://codereview.chromium.org/23087004/diff/3001/sdk/lib/core/bool.dart#new...
sdk/lib/core/bool.dart:21: * Returns [:"true":] if the receiver is [:true:], or
[:"false":] if the
On 2013/08/15 20:02:54, ahe wrote:
> I'm not sure I like adding this method. dart2js only uses this class for an
> interface, and you cannot change this method without changing implementation
> details in dart2js.

What if I declare it to be abstract, like on int/double?

[ahe, 2013-08-15 20:15:54]

lgtm

https://codereview.chromium.org/23087004/diff/3001/sdk/lib/core/bool.dart
File sdk/lib/core/bool.dart (right):

https://codereview.chromium.org/23087004/diff/3001/sdk/lib/core/bool.dart#new...
sdk/lib/core/bool.dart:21: * Returns [:"true":] if the receiver is [:true:], or
[:"false":] if the
On 2013/08/15 20:14:11, Ryan Macnak wrote:
> On 2013/08/15 20:02:54, ahe wrote:
> > I'm not sure I like adding this method. dart2js only uses this class for an
> > interface, and you cannot change this method without changing implementation
> > details in dart2js.
> 
> What if I declare it to be abstract, like on int/double?

Works for me!

[Kathy Walrath, 2013-08-15 20:49:20]

lgtm

[rmacnak, 2013-08-15 20:53:28]

Committed patchset #2 manually as r26216 (presubmit successful).