Issue 23076002: Fix Process.runSync on 64-bit Mac OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23076002: Fix Process.runSync on 64-bit Mac OS (Closed)

Created:
7 years, 4 months ago by Søren Gjesse

Modified:
7 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Process.runSync on 64-bit Mac OS Turned out that for poll on 64-bin Mac OS POLLIN set with 0 available bytes means closed even though POLLHUP is not set. Also slighty refactored the loop in the Linux version to make them look the same. R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26057

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	runtime/bin/process_linux.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
	M	runtime/bin/process_macos.cc	View		3 chunks	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years, 4 months ago (2013-08-13 15:56:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26057 (presubmit successful).

Expand Messages | Collapse Messages