Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 23074008: Only change timeout to 100ms after the connection is established. (Closed)

Created:
7 years, 4 months ago by Anders Johnsen
Modified:
7 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Only change timeout to 100ms after the connection is established. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26420

Patch Set 1 #

Total comments: 4

Patch Set 2 : Few fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M tests/standalone/io/http_server_idle_timeout_test.dart View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 4 months ago (2013-08-21 07:33:56 UTC) #1
Søren Gjesse
lgtm with comments https://codereview.chromium.org/23074008/diff/1/tests/standalone/io/http_server_idle_timeout_test.dart File tests/standalone/io/http_server_idle_timeout_test.dart (right): https://codereview.chromium.org/23074008/diff/1/tests/standalone/io/http_server_idle_timeout_test.dart#newcode16 tests/standalone/io/http_server_idle_timeout_test.dart:16: HttpServer.bind("127.0.0.1", 0).then((server) { Set server.idleTimeout to ...
7 years, 4 months ago (2013-08-21 07:39:54 UTC) #2
Anders Johnsen
https://codereview.chromium.org/23074008/diff/1/tests/standalone/io/http_server_idle_timeout_test.dart File tests/standalone/io/http_server_idle_timeout_test.dart (right): https://codereview.chromium.org/23074008/diff/1/tests/standalone/io/http_server_idle_timeout_test.dart#newcode16 tests/standalone/io/http_server_idle_timeout_test.dart:16: HttpServer.bind("127.0.0.1", 0).then((server) { On 2013/08/21 07:39:54, Søren Gjesse wrote: ...
7 years, 4 months ago (2013-08-21 07:43:49 UTC) #3
Anders Johnsen
7 years, 4 months ago (2013-08-21 07:44:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698