Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 23073005: Make pow fail for non-number arguments. (Closed)

Created:
7 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 4 months ago
Reviewers:
regis, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis
Visibility:
Public.

Description

Make pow fail for non-number arguments. Previous change removed a check that was expected by a co19 test. Committed: https://code.google.com/p/dart/source/detail?r=26351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M runtime/lib/math_patch.dart View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 4 months ago (2013-08-20 12:57:38 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r26351 (presubmit successful).
7 years, 4 months ago (2013-08-20 12:57:59 UTC) #2
floitsch
LGTM.
7 years, 4 months ago (2013-08-20 12:58:28 UTC) #3
regis
7 years, 4 months ago (2013-08-20 16:08:21 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698