Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 23072020: Disable co19 on all dart2js builders except ie9 again (Closed)

Created:
7 years, 4 months ago by kustermann
Modified:
7 years, 4 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable co19 on all dart2js builders except ie9 again TBR=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=26263

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M dart/tests/co19/co19-dart2js.status View 1 1 chunk +3 lines, -0 lines 1 comment Download
M dart/tests/co19/co19-runtime.status View 1 1 chunk +11 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
7 years, 4 months ago (2013-08-16 09:22:33 UTC) #1
kustermann
https://codereview.chromium.org/23072020/diff/6001/dart/tests/co19/co19-dart2js.status File dart/tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/23072020/diff/6001/dart/tests/co19/co19-dart2js.status#newcode267 dart/tests/co19/co19-dart2js.status:267: *: Skip This was accidentally removed by the last ...
7 years, 4 months ago (2013-08-16 09:51:01 UTC) #2
kustermann
Committed patchset #2 manually as r26263 (presubmit successful).
7 years, 4 months ago (2013-08-16 09:51:43 UTC) #3
ricow1
https://codereview.chromium.org/23072020/diff/6001/dart/tests/co19/co19-runtime.status File dart/tests/co19/co19-runtime.status (right): https://codereview.chromium.org/23072020/diff/6001/dart/tests/co19/co19-runtime.status#newcode316 dart/tests/co19/co19-runtime.status:316: LibTest/async/Stream/Stream.periodic_A01_t01: fail, pass # co19-roll r546: Please triage this ...
7 years, 4 months ago (2013-08-16 10:31:32 UTC) #4
kustermann
7 years, 4 months ago (2013-08-18 15:08:10 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/23072020/diff/6001/dart/tests/co19/co19-runti...
File dart/tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/23072020/diff/6001/dart/tests/co19/co19-runti...
dart/tests/co19/co19-runtime.status:316:
LibTest/async/Stream/Stream.periodic_A01_t01: fail, pass # co19-roll r546:
Please triage this failure
On 2013/08/16 10:31:32, ricow1 wrote:
> are these accidental edits?

No I just wanted to reduce the number of status-file update commits, so I added
these as well.

Powered by Google App Engine
This is Rietveld 408576698