Issue 23067006: Evaluate expression in context of an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23067006: Evaluate expression in context of an object (Closed)

Created:
7 years, 4 months ago by hausner

Modified:
7 years, 4 months ago

Reviewers:

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Evaluate expression in context of an object This is the core functionality needed for the debugger. Committed: https://code.google.com/p/dart/source/detail?r=26328

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+336 lines, -19 lines)			Patch
M	runtime/bin/dbg_connection.cc	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/bin/dbg_message.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/bin/dbg_message.cc	View	1 2 3	3 chunks	+57 lines, -0 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1 2 3	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/compiler_test.cc	View	1 2 3	2 chunks	+31 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2 3	3 chunks	+17 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1 2 3	12 chunks	+132 lines, -18 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	1 chunk	+52 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/ddbg.dart	View	1 2 3	3 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hausner

Committed patchset #4 manually as r26328 (presubmit successful).

7 years, 4 months ago (2013-08-19 22:17:19 UTC) #1

Ivan Posva

7 years, 4 months ago (2013-08-22 00:02:08 UTC) #2

Message was sent while issue was closed.

On 2013/08/19 22:17:19, hausner wrote:
> Committed patchset #4 manually as r26328 (presubmit successful).

This was reviewed as https://codereview.chromium.org/22909009/

-Ivan

Expand Messages | Collapse Messages