Issue 23061008: WebSocket security checks changed a bit with the latest Dartium roll so the test failed with the fo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23061008: WebSocket security checks changed a bit with the latest Dartium roll so the test failed with the fo… (Closed)

Created:
7 years, 4 months ago by Jacob

Modified:
7 years, 4 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

WebSocket security checks changed a bit with the latest Dartium roll so the test failed with the following error when protocol 'chat' was used. failed: Error during WebSocket handshake: Sec-WebSocket-Protocol mismatch" I've switched the WebSocket constructor test to pass in the protocol 'chat' so that coverage for passing in a protocol is not impacted. Note that chrome dev channel reports the same error when a JS WebSocket is created with protocol 'chat' given the same scenario. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26496

Patch Set 1 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/html/websocket_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

7 years, 4 months ago (2013-08-22 00:33:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26496 (presubmit successful).

Expand Messages | Collapse Messages