Issue 23060041: Fix api for dart2js tests that failed.

Issue 23060041: Fix api for dart2js tests that failed. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna

Modified:
7 years, 3 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix api for dart2js tests that failed. BUG= Committed: https://code.google.com/p/dart/source/detail?r=26606

Patch Set 1 : #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -125 lines)			Patch
M	pkg/custom_element/lib/custom_element.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	19 chunks	+1 line, -59 lines	2 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	18 chunks	+9 lines, -62 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR. I accidentally deleted an underscore where I shouldn't have, and removed one extra method

7 years, 4 months ago (2013-08-23 19:15:13 UTC) #1

Emily Fortuna

Committed patchset #1 manually as r26606 (presubmit successful).

7 years, 4 months ago (2013-08-23 19:15:38 UTC) #2

blois

https://codereview.chromium.org/23060041/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/23060041/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode938 sdk/lib/html/dart2js/html_dart2js.dart:938: - * Where did these comments go (especially this ...

7 years, 3 months ago (2013-08-26 16:33:52 UTC) #3

Emily Fortuna

7 years, 3 months ago (2013-08-26 16:41:50 UTC) #4

blois

7 years, 3 months ago (2013-08-26 16:53:06 UTC) #5

Message was sent while issue was closed.

On 2013/08/26 16:41:50, Emily Fortuna wrote:
>
https://codereview.chromium.org/23060041/diff/3001/sdk/lib/html/dart2js/html_...
> File sdk/lib/html/dart2js/html_dart2js.dart (left):
> 
>
https://codereview.chromium.org/23060041/diff/3001/sdk/lib/html/dart2js/html_...
> sdk/lib/html/dart2js/html_dart2js.dart:938: -   *
> On 2013/08/26 16:33:52, blois wrote:
> > Where did these comments go (especially this one)? Can they be resurrected?
> 
> When I tried to commit this other CL:
> https://code.google.com/p/dart/source/detail?r=26605 the presubmit failed, and
> it told me to run tools/dom/dom.py docs. I did, and those comments appeared
> (like the one above). Then in this CL, I ran go.sh, and noticed these comments
> had disappeared. I tried running tools/dom/dom.py docs again, but this time
the
> comments didn't come back. Since they only appeared mysteriously when I tried
to
> check in my previous CL (they weren't actually ever checked in separately), I
> just submitted this one. It was unclear when/how they got added.

Seems like they got deleted from docs.json at some point. Decent docs are rare
enough, we should maintain them when possible. Just sent a CL adding them back.

Expand Messages | Collapse Messages