Issue 230513002: Fix leaking FD from readAs*Sync and writeAs*Sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 230513002: Fix leaking FD from readAsSync and writeAsSync. (Closed)

Created:
6 years, 8 months ago by Anders Johnsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix leaking FD from readAs*Sync and writeAs*Sync. If open was succesfull but the following read/write failed, we would fail to close the file. We now intercept the error (as we correctly do in the async case) and close the file before throwing the error to the user. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34868

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -17 lines)			Patch
	M	sdk/lib/io/file_impl.dart	View		2 chunks	+23 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

6 years, 8 months ago (2014-04-09 10:38:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34868 (presubmit successful).

Expand Messages | Collapse Messages

Issue 230513002: Fix leaking FD from readAs*Sync and writeAs*Sync. (Closed)

Description

Patch Set 1 #

Messages

Issue 230513002: Fix leaking FD from readAsSync and writeAsSync. (Closed)