Issue 23045007: Mirror printer test.

Issue 23045007: Mirror printer test. (Closed)

Created:
7 years, 4 months ago by ahe

Modified:
7 years, 3 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, ngeoffray, zarah, Michael Lippautz (Google), rmacnak

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Mirror printer test. BUG=http://dartbug.com/12134 R=karlklose@google.com, ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26916

Patch Set 2 : Address comments and fix crash. #

Patch Set 3 : Merged with r26910, added more tests, and fixed issues. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -30 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	2 chunks	+3 lines, -8 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	5 chunks	+11 lines, -5 lines	0 comments	Download
A +	dart/tests/compiler/dart2js_extra/crash_library_metadata.dart	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
A	dart/tests/compiler/dart2js_extra/mirror_printer_test.dart	View	1	1 chunk	+182 lines, -0 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
A +	dart/tests/lib/mirrors/library_metadata2_lib1.dart	View	1 2	1 chunk	+5 lines, -3 lines	0 comments	Download
A +	dart/tests/lib/mirrors/library_metadata2_lib2.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
A +	dart/tests/lib/mirrors/library_metadata2_test.dart	View	1 2	1 chunk	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/23045007/diff/2001/dart/tests/compiler/dart2js_extra/mirror_printer_test.dart File dart/tests/compiler/dart2js_extra/mirror_printer_test.dart (right): https://codereview.chromium.org/23045007/diff/2001/dart/tests/compiler/dart2js_extra/mirror_printer_test.dart#newcode1 dart/tests/compiler/dart2js_extra/mirror_printer_test.dart:1: // Copyright (c) 2013, the Dart project authors. ...

7 years, 4 months ago (2013-08-16 12:52:45 UTC) #2

karlklose

LGTM. https://codereview.chromium.org/23045007/diff/2001/dart/tests/compiler/dart2js_extra/mirror_printer_test.dart File dart/tests/compiler/dart2js_extra/mirror_printer_test.dart (right): https://codereview.chromium.org/23045007/diff/2001/dart/tests/compiler/dart2js_extra/mirror_printer_test.dart#newcode5 dart/tests/compiler/dart2js_extra/mirror_printer_test.dart:5: // Prints all information about all mirrors. 'Tests ...

7 years, 4 months ago (2013-08-16 12:53:09 UTC) #3

ahe

PTAL https://codereview.chromium.org/23045007/diff/2001/dart/tests/compiler/dart2js_extra/mirror_printer_test.dart File dart/tests/compiler/dart2js_extra/mirror_printer_test.dart (right): https://codereview.chromium.org/23045007/diff/2001/dart/tests/compiler/dart2js_extra/mirror_printer_test.dart#newcode1 dart/tests/compiler/dart2js_extra/mirror_printer_test.dart:1: // Copyright (c) 2013, the Dart project authors. ...

7 years, 3 months ago (2013-08-30 13:43:47 UTC) #4

ahe

7 years, 3 months ago (2013-08-30 13:52:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 manually as r26916 (presubmit successful).

Expand Messages | Collapse Messages