Issue 230443002: Fix dart2js custom hashmap/set not using the custom method for string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 230443002: Fix dart2js custom hashmap/set not using the custom method for string. (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart2js custom hashmap/set not using the custom method for string. BUG= http://dartbug.com/18109 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=34870

Patch Set 2 : Remove print. Add test files. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -151 lines)			Patch
M	sdk/lib/_internal/lib/collection_patch.dart	View	1	18 chunks	+227 lines, -151 lines	0 comments	Download
A	tests/lib/collection/hash_map_test.dart	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
A	tests/lib/collection/hash_set_test.dart	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

We could refactor the code, so the _-methods I introduced are the actual implementation on ...

6 years, 8 months ago (2014-04-09 08:39:56 UTC) #1

floitsch

LGTM with tests. https://codereview.chromium.org/230443002/diff/1/sdk/lib/_internal/lib/collection_patch.dart File sdk/lib/_internal/lib/collection_patch.dart (right): https://codereview.chromium.org/230443002/diff/1/sdk/lib/_internal/lib/collection_patch.dart#newcode91 sdk/lib/_internal/lib/collection_patch.dart:91: print("ck: $key"); remove. https://codereview.chromium.org/230443002/diff/1/sdk/lib/_internal/lib/collection_patch.dart#newcode95 sdk/lib/_internal/lib/collection_patch.dart:95: print(bucket); ...

6 years, 8 months ago (2014-04-09 09:24:27 UTC) #2

Lasse Reichstein Nielsen

6 years, 8 months ago (2014-04-09 11:02:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34870 (presubmit successful).

Expand Messages | Collapse Messages

Issue 230443002: Fix dart2js custom hashmap/set not using the custom method for string. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove print. Add test files. #

Messages