Formatter cleanup.

Formatter cleanup.

Migration to emitToken begins...

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26079

[Brian Wilkerson, 2013-08-13 20:03:24]

LGTM

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:166:
visitPrefixed('.', node.constructorName);
This might want to be
  if (node.constructorName != null) {
    emitToken(node.period);
    visit(node.constructorName);
  }
(unless visitPrefixed can take a token).

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:188:
emitToken(node.keyword, suffix: ' (');
This might want to be
  emitToken(node.keyword);
  emitToken(node.leftParenthesis);
(with some whitespace thrown in somewhere).

I'll stop commenting on hard-coded tokens; not sure you were done anyway.

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:226:
print(node.literal.lexeme);
Why not "emitToken(node.literal)"?

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:342:
emitToken(node.keyword, suffix: ' ');
This looks like it would put two spaces between 'continue' and a label (one here
and one on the next line).

[pquitslund, 2013-08-13 20:08:01]

Thanks Brian!

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:188:
emitToken(node.keyword, suffix: ' (');
On 2013/08/13 20:03:24, Brian Wilkerson wrote:
> This might want to be
>   emitToken(node.keyword);
>   emitToken(node.leftParenthesis);
> (with some whitespace thrown in somewhere).
> 
> I'll stop commenting on hard-coded tokens; not sure you were done anyway.

Not done but point taken.  I think that *is* the direction we want to go.

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:226:
print(node.literal.lexeme);
On 2013/08/13 20:03:24, Brian Wilkerson wrote:
> Why not "emitToken(node.literal)"?

Because I missed it! :)  A few I'm holdng off on to better understand the
ramifications but this one I just overlooked.

https://codereview.chromium.org/23044004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:342:
emitToken(node.keyword, suffix: ' ');
On 2013/08/13 20:03:24, Brian Wilkerson wrote:
> This looks like it would put two spaces between 'continue' and a label (one
here
> and one on the next line).

Good catch!  Fixed.

[pquitslund, 2013-08-13 20:08:50]

Committed patchset #4 manually as r26079 (presubmit successful).