Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 23039018: fix polymer tests on windows (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -19 lines) Patch
M pkg/polymer/test/compiler_test.dart View 2 chunks +11 lines, -10 lines 0 comments Download
M pkg/polymer/test/css_test.dart View 2 chunks +19 lines, -7 lines 0 comments Download
M pkg/polymer/test/paths_test.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
I switched one test to use path.join, otherwise it just uses Posix style paths for ...
7 years, 4 months ago (2013-08-20 23:25:18 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 4 months ago (2013-08-20 23:26:27 UTC) #2
Jennifer Messerly
7 years, 4 months ago (2013-08-20 23:26:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26409 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698