Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 23038018: Factor a PhaseOutput class out of Phase. (Closed)

Created:
7 years, 4 months ago by nweiz
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Factor a PhaseOutput class out of Phase. This lays the groundwork for supporting a cross-package transform picking up on a new transform that applies to one of its secondary inputs. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26545

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -88 lines) Patch
M pkg/barback/lib/src/asset_forwarder.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/barback/lib/src/asset_node.dart View 1 4 chunks +26 lines, -4 lines 0 comments Download
M pkg/barback/lib/src/phase.dart View 6 chunks +27 lines, -77 lines 0 comments Download
A pkg/barback/lib/src/phase_output.dart View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 4 months ago (2013-08-21 20:38:06 UTC) #1
Bob Nystrom
Very nice. LGTM. https://codereview.chromium.org/23038018/diff/1/pkg/barback/lib/src/asset_node.dart File pkg/barback/lib/src/asset_node.dart (right): https://codereview.chromium.org/23038018/diff/1/pkg/barback/lib/src/asset_node.dart#newcode183 pkg/barback/lib/src/asset_node.dart:183: /// Sets the node's [AssetNode.transform] property. ...
7 years, 4 months ago (2013-08-21 21:23:40 UTC) #2
nweiz
https://codereview.chromium.org/23038018/diff/1/pkg/barback/lib/src/asset_node.dart File pkg/barback/lib/src/asset_node.dart (right): https://codereview.chromium.org/23038018/diff/1/pkg/barback/lib/src/asset_node.dart#newcode183 pkg/barback/lib/src/asset_node.dart:183: /// Sets the node's [AssetNode.transform] property. On 2013/08/21 21:23:40, ...
7 years, 4 months ago (2013-08-22 18:30:49 UTC) #3
nweiz
7 years, 4 months ago (2013-08-22 18:31:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26545 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698