Issue 23035004: Fix Windows bugs in r26181

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23035004: Fix Windows bugs in r26181 (Closed)

Created:
7 years, 4 months ago by Søren Gjesse

Modified:
7 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Windows bugs in r26181 TBR=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26191

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	tests/lib/mirrors/library_uri_io_test.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	utils/compiler/create_snapshot.dart	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r26191 (presubmit successful).

7 years, 4 months ago (2013-08-15 12:10:24 UTC) #2

ahe

7 years, 4 months ago (2013-08-15 12:14:07 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/23035004/diff/1/utils/compiler/create_snapsho...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/23035004/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:25: import '${dart2js.toFilePath(windows:
false)}' as dart2jsMain;
This still isn't right. dart2js is already a URI, so it should just be:

import '$dart2js' as dart2jsMain;

Since calling toString on a URI should produce something that is valid at this
point.

Expand Messages | Collapse Messages