Issue 23026004: Clean up VM class DartFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23026004: Clean up VM class DartFunction. (Closed)

Created:
7 years, 4 months ago by Florian Schneider

Modified:
7 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Clean up VM class DartFunction. DartFunction was the VM-internal class associated with the Dart class "Function". It does not have any functionality on it and therefore we don't need a VM-internal class for it. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26063

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -57 lines)			Patch
M	runtime/vm/class_finalizer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+3 lines, -15 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/raw_object.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View		2 chunks	+1 line, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

This is a clean up only change - As we discussed off-line, I thought this ...

7 years, 4 months ago (2013-08-13 16:48:36 UTC) #1

Florian Schneider

7 years, 4 months ago (2013-08-13 17:05:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r26063 (presubmit successful).

Expand Messages | Collapse Messages