Add add and subtract operations to Uint32x4

Add add and subtract operations to Uint32x4

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26358

[srdjan, 2013-08-19 21:45:23]

https://codereview.chromium.org/23018009/diff/3001/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/lib/typed_data.dar...
runtime/lib/typed_data.dart:2084: Uint32x4 operator +(Uint32x4 other) {
Why go via a helper method instead of making it native?

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3637: break;
fix indent of 'break' (also below).

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:3692: break;
ditto

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_x64.cc:3734: case Token::kSUB:
ditto

https://codereview.chromium.org/23018009/diff/3001/sdk/lib/typed_data/dart2js...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://codereview.chromium.org/23018009/diff/3001/sdk/lib/typed_data/dart2js...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1401: r._storage[0] =
(_storage[0] + other._storage[0])|0;
Why '| 0'? In JS this creates an uint32 but shouldn't  dart2js emit appropriate
code instead of writing JS like code in Dart?

[Cutch, 2013-08-19 21:58:25]

https://codereview.chromium.org/23018009/diff/3001/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/lib/typed_data.dar...
runtime/lib/typed_data.dart:2084: Uint32x4 operator +(Uint32x4 other) {
On 2013/08/19 21:45:23, srdjan wrote:
> Why go via a helper method instead of making it native?

Legacy. Will follow up with a cleanup CL.

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_arm.cc:3637: break;
On 2013/08/19 21:45:23, srdjan wrote:
> fix indent of 'break' (also below).

Done.

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_ia32.cc:3692: break;
On 2013/08/19 21:45:23, srdjan wrote:
> ditto

Done.

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/23018009/diff/3001/runtime/vm/intermediate_la...
runtime/vm/intermediate_language_x64.cc:3734: case Token::kSUB:
On 2013/08/19 21:45:23, srdjan wrote:
> ditto

Done.

https://codereview.chromium.org/23018009/diff/3001/sdk/lib/typed_data/dart2js...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://codereview.chromium.org/23018009/diff/3001/sdk/lib/typed_data/dart2js...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:1401: r._storage[0] =
(_storage[0] + other._storage[0])|0;
On 2013/08/19 21:45:23, srdjan wrote:
> Why '| 0'? In JS this creates an uint32 but shouldn't  dart2js emit
appropriate
> code instead of writing JS like code in Dart? 

Done.

[srdjan, 2013-08-19 23:51:11]

lgtm

[Cutch, 2013-08-20 14:34:12]

Committed patchset #3 manually as r26358 (presubmit successful).