Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 230163003: Add new failures to status files, assign issues. (Closed)

Created:
6 years, 8 months ago by Bill Hesse
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Add new failures to status files, assign issues. BUG=dartbug.com/18113 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=34863

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/pkg.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +2 lines, -0 lines 3 comments Download

Messages

Total messages: 9 (0 generated)
Bill Hesse
6 years, 8 months ago (2014-04-09 07:59:31 UTC) #1
ricow1
https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status#newcode130 tests/corelib/corelib.status:130: string_case_test/02: Fail, OK # Bug in Chrome. Please file ...
6 years, 8 months ago (2014-04-09 08:10:56 UTC) #2
ricow1
and LGTM, thanks
6 years, 8 months ago (2014-04-09 08:11:08 UTC) #3
Bill Hesse
On 2014/04/09 08:10:56, ricow1 wrote: > https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status > File tests/corelib/corelib.status (right): > > https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status#newcode130 > ...
6 years, 8 months ago (2014-04-09 08:29:49 UTC) #4
Bill Hesse
Committed patchset #1 manually as r34863 (presubmit successful).
6 years, 8 months ago (2014-04-09 08:30:38 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status#newcode130 tests/corelib/corelib.status:130: string_case_test/02: Fail, OK # Bug in Chrome. Please file ...
6 years, 8 months ago (2014-04-09 08:54:44 UTC) #6
Lasse Reichstein Nielsen
https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/230163003/diff/1/tests/corelib/corelib.status#newcode130 tests/corelib/corelib.status:130: string_case_test/02: Fail, OK # Bug in Chrome. Please file ...
6 years, 8 months ago (2014-04-09 08:57:04 UTC) #7
Lasse Reichstein Nielsen
Neither blind, nor senile - the bug was in the chromium tracker, not the v8 ...
6 years, 8 months ago (2014-04-09 09:21:36 UTC) #8
ricow1
6 years, 8 months ago (2014-04-09 09:28:55 UTC) #9
Message was sent while issue was closed.
On 2014/04/09 09:21:36, Lasse Reichstein Nielsen wrote:
> Neither blind, nor senile - the bug was in the chromium tracker, not the v8
one.
> The issue was fixed in v8 r20197, but apparently hasn't reached the v8
versions
> that we use yet.

Do you have a link, it would be nice to annotate the line in the status file
with the issue number

Powered by Google App Engine
This is Rietveld 408576698