Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 23011045: Declare the sequence of phases for the full polymer transform and add tests for (Closed)

Created:
7 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Declare the sequence of phases for the full polymer transform and add tests for it. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26574

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -20 lines) Patch
M pkg/polymer/lib/src/transform.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/transform/code_extractor.dart View 1 1 chunk +24 lines, -12 lines 0 comments Download
M pkg/polymer/lib/src/transform/script_compactor.dart View 3 chunks +27 lines, -8 lines 0 comments Download
M pkg/polymer/test/run_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/polymer/test/transform/all_phases_test.dart View 1 chunk +206 lines, -0 lines 0 comments Download
M pkg/polymer/test/transform/script_compactor_test.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
With these changes I got todomvc running on pub-serve on my local machine, pretty exiciting!
7 years, 4 months ago (2013-08-22 18:26:27 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/23011045/diff/6001/pkg/polymer/lib/src/transform/code_extractor.dart File pkg/polymer/lib/src/transform/code_extractor.dart (right): https://codereview.chromium.org/23011045/diff/6001/pkg/polymer/lib/src/transform/code_extractor.dart#newcode38 pkg/polymer/lib/src/transform/code_extractor.dart:38: count++; instead of count, a boolean "htmlChanged" might ...
7 years, 4 months ago (2013-08-23 01:23:11 UTC) #2
Siggi Cherem (dart-lang)
thx! https://codereview.chromium.org/23011045/diff/6001/pkg/polymer/lib/src/transform/code_extractor.dart File pkg/polymer/lib/src/transform/code_extractor.dart (right): https://codereview.chromium.org/23011045/diff/6001/pkg/polymer/lib/src/transform/code_extractor.dart#newcode38 pkg/polymer/lib/src/transform/code_extractor.dart:38: count++; On 2013/08/23 01:23:11, John Messerly wrote: > ...
7 years, 4 months ago (2013-08-23 01:45:28 UTC) #3
Siggi Cherem (dart-lang)
7 years, 4 months ago (2013-08-23 01:45:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698