Issue 23011043: Correctly clone comparisons in branch optimizations of Dart VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23011043: Correctly clone comparisons in branch optimizations of Dart VM. (Closed)

Created:
7 years, 4 months ago by Florian Schneider

Modified:
7 years, 4 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Correctly clone comparisons in branch optimizations of Dart VM. When cloning comparisons of branches, the type feedback of some comparisons was lost, resulting in slower generic code instead of type-specialized code. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=26514

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 4 months ago (2013-08-22 11:03:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26514 (presubmit successful).

Expand Messages | Collapse Messages