Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 23004015: Remove assertion in compile-time constant map literals (Closed)

Created:
7 years, 4 months ago by hausner
Modified:
7 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove assertion in compile-time constant map literals We had a left-over assertion that keys are strings. Fixes issue 12505. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=26549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/vm/parser.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 4 months ago (2013-08-22 18:05:04 UTC) #1
regis
LGTM
7 years, 4 months ago (2013-08-22 19:30:33 UTC) #2
hausner
7 years, 4 months ago (2013-08-22 19:45:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26549 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698