Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 23004006: Suppress getPresentationAttribute (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
Reviewers:
Jacob, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Suppress getPresentationAttribute Should fix analyzer bot. TBR=jacobr@google.com,blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+666 lines, -536 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 30 chunks +293 lines, -215 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 34 chunks +262 lines, -241 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 32 chunks +52 lines, -38 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 32 chunks +58 lines, -42 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
Committed patchset #1 manually as r26364 (presubmit successful).
7 years, 4 months ago (2013-08-20 16:19:10 UTC) #1
blois
Seems like this rolls back the IDL changes from the blink roll?
7 years, 4 months ago (2013-08-20 16:45:26 UTC) #2
Jacob
7 years, 4 months ago (2013-08-20 16:47:36 UTC) #3
Message was sent while issue was closed.
we'll roll the IDL changes forward as part of one of the next CLs.

lgtm

Powered by Google App Engine
This is Rietveld 408576698