Extract interceptor calls from raw is-checks.

Extract interceptor calls from raw is-checks.

BUG=
R=ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26620

Committed: https://code.google.com/p/dart/source/detail?r=26626

Committed: https://code.google.com/p/dart/source/detail?r=26701

[ngeoffray, 2013-08-24 11:16:25]

LGTM!

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:34: return
compiler.withCurrentElement(element, () {
Since the build method is the entry point of the builder, this looks kind of
odd. What motivated it?

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2803: return new
HIs.raw(type, expression ,invokeInterceptor(expression));
move space around last comma.

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2869: if (element ==
compiler.stringClass ||
Maybe add a "backend.hasDirectCheckFor(element)" in the Backend class.

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right):

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:2235: {this.nullOk:
false}) : super(inputs) {
I think we can remove 'nullOK' now, it does not look used.

[Johnni Winther, 2013-08-26 07:11:18]

Committed patchset #5 manually as r26620 (presubmit successful).

[Johnni Winther, 2013-08-26 07:34:00]

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:34: return
compiler.withCurrentElement(element, () {
On 2013/08/24 11:16:26, ngeoffray wrote:
> Since the build method is the entry point of the builder, this looks kind of
> odd. What motivated it?

The current element was the declaration and not the implementation, leading to
crashes when trying to use the reportHere method for debugging.

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2803: return new
HIs.raw(type, expression ,invokeInterceptor(expression));
On 2013/08/24 11:16:26, ngeoffray wrote:
> move space around last comma.

Done.

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:2869: if (element ==
compiler.stringClass ||
On 2013/08/24 11:16:26, ngeoffray wrote:
> Maybe add a "backend.hasDirectCheckFor(element)" in the Backend class.

Done.

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (right):

https://codereview.chromium.org/23003031/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/nodes.dart:2235: {this.nullOk:
false}) : super(inputs) {
On 2013/08/24 11:16:26, ngeoffray wrote:
> I think we can remove 'nullOK' now, it does not look used.

Done.

[Johnni Winther, 2013-08-26 08:56:57]

@ngeoffray: PTAL at the latest patch

[ngeoffray, 2013-08-26 09:10:23]

LGTM!

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart
(right):

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:194:
if (user is HIs) {
Add a comment.

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:196:
// interceptor.
I think you should move this TODO in the builder: buildIsNode.

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:257: 
Get rid of extra line.

https://codereview.chromium.org/23003031/diff/20001/tests/compiler/dart2js/si...
File tests/compiler/dart2js/simple_function_subtype_test.dart (right):

https://codereview.chromium.org/23003031/diff/20001/tests/compiler/dart2js/si...
tests/compiler/dart2js/simple_function_subtype_test.dart:53: print(generated);
Remove print.

[Johnni Winther, 2013-08-26 09:30:14]

Committed patchset #8 manually as r26626 (presubmit successful).

[Johnni Winther, 2013-08-27 08:45:44]

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart
(right):

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:194:
if (user is HIs) {
On 2013/08/26 09:10:23, ngeoffray wrote:
> Add a comment.

Done.

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:196:
// interceptor.
On 2013/08/26 09:10:23, ngeoffray wrote:
> I think you should move this TODO in the builder: buildIsNode.

Done.

https://codereview.chromium.org/23003031/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart:257: 
On 2013/08/26 09:10:23, ngeoffray wrote:
> Get rid of extra line.

Done.

https://codereview.chromium.org/23003031/diff/20001/tests/compiler/dart2js/si...
File tests/compiler/dart2js/simple_function_subtype_test.dart (right):

https://codereview.chromium.org/23003031/diff/20001/tests/compiler/dart2js/si...
tests/compiler/dart2js/simple_function_subtype_test.dart:53: print(generated);
On 2013/08/26 09:10:23, ngeoffray wrote:
> Remove print.

Done.

[Johnni Winther, 2013-08-27 08:50:45]

@ngeoffray: PTAL at latest patch

[ngeoffray, 2013-08-27 08:55:02]

LGTM

https://codereview.chromium.org/23003031/diff/51001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/23003031/diff/51001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:710:
addInterceptors(jsInterceptorClass, enqueuer, elements);
Maybe move the registration of the super class in addInterceptors?

https://codereview.chromium.org/23003031/diff/51001/tests/compiler/dart2js/si...
File tests/compiler/dart2js/simple_function_subtype_test.dart (right):

https://codereview.chromium.org/23003031/diff/51001/tests/compiler/dart2js/si...
tests/compiler/dart2js/simple_function_subtype_test.dart:53: print(generated);
Remove print.

[Johnni Winther, 2013-08-27 10:20:10]

https://codereview.chromium.org/23003031/diff/51001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/23003031/diff/51001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:710:
addInterceptors(jsInterceptorClass, enqueuer, elements);
On 2013/08/27 08:55:02, ngeoffray wrote:
> Maybe move the registration of the super class in addInterceptors?

Done.

https://codereview.chromium.org/23003031/diff/51001/tests/compiler/dart2js/si...
File tests/compiler/dart2js/simple_function_subtype_test.dart (right):

https://codereview.chromium.org/23003031/diff/51001/tests/compiler/dart2js/si...
tests/compiler/dart2js/simple_function_subtype_test.dart:53: print(generated);
On 2013/08/27 08:55:02, ngeoffray wrote:
> Remove print.

Done.

[Johnni Winther, 2013-08-27 10:29:25]

Committed patchset #11 manually as r26701 (presubmit successful).