Issue 23000008: Fixes scanning of Utf16 surrogate pairs in string literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23000008: Fixes scanning of Utf16 surrogate pairs in string literals. (Closed)

Created:
7 years, 4 months ago by zra

Modified:
7 years, 4 months ago

Reviewers:
dgrove, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes scanning of Utf16 surrogate pairs in string literals. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26130

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/scanner.cc	View	1	1 chunk	+11 lines, -1 line	0 comments	Download
A	tests/language/unicode_hash_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zra

This will fix: https://code.google.com/p/dart/issues/detail?id=12412

7 years, 4 months ago (2013-08-13 23:00:11 UTC) #1

Ivan Posva

https://codereview.chromium.org/23000008/diff/1/runtime/vm/scanner.cc File runtime/vm/scanner.cc (right): https://codereview.chromium.org/23000008/diff/1/runtime/vm/scanner.cc#newcode594 runtime/vm/scanner.cc:594: continue; Can you restructure this to avoid the continue?

7 years, 4 months ago (2013-08-14 05:21:52 UTC) #2

zra

Should I also emit an error message on an unmatched lead surrogate? https://codereview.chromium.org/23000008/diff/1/runtime/vm/scanner.cc File runtime/vm/scanner.cc ...

7 years, 4 months ago (2013-08-14 14:59:11 UTC) #3

zra

7 years, 4 months ago (2013-08-14 17:34:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r26130 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23000008: Fixes scanning of Utf16 surrogate pairs in string literals. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages