Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 23000003: Fix issue 12288: a getter also returns something. (Closed)

Created:
7 years, 4 months ago by ngeoffray
Modified:
7 years, 4 months ago
Reviewers:
ahe, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 12288: a getter also returns something. R=ahe@google.com, kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/container_tracer.dart View 1 chunk +1 line, -3 lines 0 comments Download
A tests/language/issue12288_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years, 4 months ago (2013-08-13 14:03:08 UTC) #1
kustermann
lgtm as far as I understand.
7 years, 4 months ago (2013-08-13 14:10:10 UTC) #2
ahe
lgtm
7 years, 4 months ago (2013-08-13 14:31:45 UTC) #3
ngeoffray
7 years, 4 months ago (2013-08-13 14:32:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698