Issue 22999037: Mark chunked_conversion_utf88 as slow on simarm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22999037: Mark chunked_conversion_utf88 as slow on simarm. (Closed)

Created:
7 years, 4 months ago by floitsch

Modified:
7 years, 4 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark chunked_conversion_utf88 as slow on simarm. Committed: https://code.google.com/p/dart/source/detail?r=26531

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r26531 (presubmit successful).

7 years, 4 months ago (2013-08-22 16:09:34 UTC) #3

kustermann

7 years, 4 months ago (2013-08-22 16:11:59 UTC) #4

Message was sent while issue was closed.

lgtm -- I was just about to do the same thing.

https://codereview.chromium.org/22999037/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/22999037/diff/1/tests/lib/lib.status#newcode129
tests/lib/lib.status:129: convert/chunked_conversion_utf88_test: Pass, Slow #
Issue 12644.
Why including arm as well? I haven't seen any timeouts on arm (we've an ARM FYI
builder)

Expand Messages | Collapse Messages