Report compile-time errors for conflicting overrides as specified by latest

Report compile-time errors for conflicting overrides as specified by latest
language spec (fix issue 12342).
Add override conflict tests.
Update status files.
Add support for 'ok' status in multi-tests.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26302

[regis, 2013-08-16 01:33:40]

I still need to mark failing tests for dart2js, dart2dart, and analyzer.

Thanks,
Regis

[hausner, 2013-08-16 16:25:43]

LGTM. I would also ask Gilad whether he can LGTM the tests.

[regis, 2013-08-16 16:51:36]

Thanks Matthias.

Good point: Gilad, would you mind reviewing the new tests? Thanks.

Cheers,
Regis

[gbracha, 2013-08-16 18:34:48]

See comments

https://codereview.chromium.org/22999022/diff/1/tests/language/field_override...
File tests/language/field_override3_test.dart (right):

https://codereview.chromium.org/22999022/diff/1/tests/language/field_override...
tests/language/field_override3_test.dart:14: set foo(value) { }
This should be an error

https://codereview.chromium.org/22999022/diff/1/tests/language/method_overrid...
File tests/language/method_override7_test.dart (right):

https://codereview.chromium.org/22999022/diff/1/tests/language/method_overrid...
tests/language/method_override7_test.dart:14: set foo(value) { }
This is now a warning.

[regis, 2013-08-16 23:18:30]

Thanks!

I have added 4 more tests for instance method, instance field, instance getter,
and instance setter.
I needed to add support for a 'ok' status in multi-tests in order to tests that
we do not report any errors or warnings.

https://codereview.chromium.org/22999022/diff/1/tests/language/field_override...
File tests/language/field_override3_test.dart (right):

https://codereview.chromium.org/22999022/diff/1/tests/language/field_override...
tests/language/field_override3_test.dart:14: set foo(value) { }
On 2013/08/16 18:34:49, gbracha wrote:
> This should be an error

Done.

https://codereview.chromium.org/22999022/diff/1/tests/language/method_overrid...
File tests/language/method_override7_test.dart (right):

https://codereview.chromium.org/22999022/diff/1/tests/language/method_overrid...
tests/language/method_override7_test.dart:14: set foo(value) { }
On 2013/08/16 18:34:49, gbracha wrote:
> This is now a warning.

Done.

[regis, 2013-08-16 23:39:48]

Committed patchset #2 manually as r26302 (presubmit successful).

[ahe, 2013-08-28 13:10:43]

DBC/FYI

Yay! Regis implemented "positive" multitests. This makes it much easier to cope
with bugs in various implementations (for example, I could have avoided creating
language/round_test yesterday :-)

https://codereview.chromium.org/22999022/diff/11001/tools/testing/dart/multit...
File tools/testing/dart/multitest.dart (right):

https://codereview.chromium.org/22999022/diff/11001/tools/testing/dart/multit...
tools/testing/dart/multitest.dart:80: ['ok', 'compile-time error', 'runtime
error',
This is really nice, and it would have been great if you had told Martin and
Rico about it.

Both Lasse and I have wanted to have this feature available for some time, but I
personally thought it would be more complicated.