Issue 22999008: Handle watching a non-existent directory.

Issue 22999008: Handle watching a non-existent directory. (Closed)

Created:
7 years, 4 months ago by Bob Nystrom

Modified:
7 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle watching a non-existent directory. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26153

Patch Set 2 : Revise. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -26 lines)			Patch
M	pkg/watcher/lib/src/directory_watcher.dart	View	1	2 chunks	+21 lines, -6 lines	0 comments	Download
A	pkg/watcher/lib/src/utils.dart	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	pkg/watcher/test/directory_watcher_test.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	pkg/watcher/test/utils.dart	View	1	3 chunks	+49 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

A few comments, otherwise lgtm https://codereview.chromium.org/22999008/diff/1/pkg/watcher/lib/src/directory_watcher.dart File pkg/watcher/lib/src/directory_watcher.dart (right): https://codereview.chromium.org/22999008/diff/1/pkg/watcher/lib/src/directory_watcher.dart#newcode136 pkg/watcher/lib/src/directory_watcher.dart:136: // If an error ...

7 years, 4 months ago (2013-08-14 19:43:11 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r26153 (presubmit successful).

7 years, 4 months ago (2013-08-14 21:02:13 UTC) #3

Bob Nystrom

7 years, 4 months ago (2013-08-16 21:40:19 UTC) #4

Message was sent while issue was closed.

Forgot to send these out...

https://codereview.chromium.org/22999008/diff/1/pkg/watcher/lib/src/directory...
File pkg/watcher/lib/src/directory_watcher.dart (right):

https://codereview.chromium.org/22999008/diff/1/pkg/watcher/lib/src/directory...
pkg/watcher/lib/src/directory_watcher.dart:136: // If an error occurred during
the listing, it usually means the
On 2013/08/14 19:43:11, nweiz wrote:
> Check if the error is the error we expect from the directory getting deleted,
> and print an error message describing what it actually is if not.

Done. Instead of printing it, I pipe the error to the event stream's error
channel.

https://codereview.chromium.org/22999008/diff/1/pkg/watcher/test/utils.dart
File pkg/watcher/test/utils.dart (right):

https://codereview.chromium.org/22999008/diff/1/pkg/watcher/test/utils.dart#n...
pkg/watcher/test/utils.dart:114: // Create an expectation for every as many
paths as we have.
On 2013/08/14 19:43:11, nweiz wrote:
> delete "every"

Done.

https://codereview.chromium.org/22999008/diff/1/pkg/watcher/test/utils.dart#n...
pkg/watcher/test/utils.dart:118: // Immediately create the futures. This ensures
we don't register too late and
On 2013/08/14 19:43:11, nweiz wrote:
> long line

Done.

Expand Messages | Collapse Messages