Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 22999005: Make analyzer happy and use annotations the right way. (Closed)

Created:
7 years, 4 months ago by ngeoffray
Modified:
7 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make analyzer happy and use annotations the right way. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M tests/language/inferrer_constructor2_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/language/inferrer_constructor3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/issue12284_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/multiple_field_assignment_constructor_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 4 months ago (2013-08-14 13:17:06 UTC) #1
ahe
LGTM!
7 years, 4 months ago (2013-08-14 13:25:59 UTC) #2
ngeoffray
7 years, 4 months ago (2013-08-14 13:30:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26120 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698