Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 22997004: Turn strict mode off in the dartanalyzer (Closed)

Created:
7 years, 4 months ago by jwren
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisOptionsImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/custom_element/lib/custom_element.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jwren
7 years, 4 months ago (2013-08-14 18:22:35 UTC) #1
Brian Wilkerson
LGTM. At some point we should go back and clean up StrictModeTest since it isn't ...
7 years, 4 months ago (2013-08-14 18:25:40 UTC) #2
scheglov
LGTM
7 years, 4 months ago (2013-08-14 18:53:17 UTC) #3
jwren
Committed patchset #1 manually as r26139 (presubmit successful).
7 years, 4 months ago (2013-08-14 19:33:03 UTC) #4
Jennifer Messerly
7 years, 4 months ago (2013-08-14 20:35:06 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698