Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2298993002: Handle metadata annotations in parameter lists with trailing commas. (Closed)

Created:
4 years, 3 months ago by Bob Nystrom
Modified:
4 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle metadata annotations in parameter lists with trailing commas. Fix #520. R=nweiz@google.com Committed: https://github.com/dart-lang/dart_style/commit/789e3444461e10aff0b50bcdd630e2706f466faa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -7 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 4 chunks +4 lines, -2 lines 0 comments Download
M pubspec.lock View 3 chunks +9 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A test/regression/0500/0520.unit View 1 chunk +18 lines, -0 lines 0 comments Download
M test/whitespace/metadata.unit View 1 chunk +20 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 3 months ago (2016-08-31 21:52:07 UTC) #2
nweiz
lgtm
4 years, 3 months ago (2016-08-31 23:34:17 UTC) #3
Bob Nystrom
4 years, 3 months ago (2016-09-01 00:11:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
789e3444461e10aff0b50bcdd630e2706f466faa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698