Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 22986022: Fixing dart2js codesize regression from blink roll. (Closed)

Created:
7 years, 4 months ago by blois
Modified:
7 years, 4 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing dart2js codesize regression from blink roll. New ErrorEvent.error was pulling in everything. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=26468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 4 months ago (2013-08-21 19:23:59 UTC) #1
sra1
lgtm
7 years, 4 months ago (2013-08-21 20:15:06 UTC) #2
blois
7 years, 4 months ago (2013-08-21 20:27:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698