Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 22986014: Add a null check to avoid trying to load libraries that don't exist. (Closed)

Created:
7 years, 4 months ago by Alan Knight
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a null check to avoid trying to load libraries that don't exist. R=efortuna@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=26377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/intl/lib/generate_localized.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
7 years, 4 months ago (2013-08-20 17:23:28 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 4 months ago (2013-08-20 17:28:53 UTC) #2
Emily Fortuna
lgtm
7 years, 4 months ago (2013-08-20 18:02:07 UTC) #3
Alan Knight
7 years, 4 months ago (2013-08-20 18:22:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26377 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698