Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 229833003: Don't treat the primary input as a secondary input in barback. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't treat the primary input as a secondary input in barback. Some transformers use [Transform.readInputAsString] to read their primary input, which puts it into a weird state of being considered both a primary and a secondary input. This ensures that it always goes through the normal [primaryInput] path. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=34905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/barback/lib/src/transform.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 8 months ago (2014-04-09 00:44:08 UTC) #1
Bob Nystrom
Does this affect any visible behavior? If so, can it be tested?
6 years, 8 months ago (2014-04-09 18:07:47 UTC) #2
nweiz
On 2014/04/09 18:07:47, Bob Nystrom wrote: > Does this affect any visible behavior? If so, ...
6 years, 8 months ago (2014-04-09 21:24:31 UTC) #3
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-09 23:33:09 UTC) #4
nweiz
6 years, 8 months ago (2014-04-09 23:51:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r34905 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698