Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 22979003: add a const ctor to Converter (Closed)

Created:
7 years, 4 months ago by kevmoo-old
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add a const ctor to Converter Nice to have const converter subclasses R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=26072

Patch Set 1 #

Patch Set 2 : updated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M sdk/lib/convert/converter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/convert/codec1_test.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
7 years, 4 months ago (2013-08-13 00:01:57 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 4 months ago (2013-08-13 08:58:45 UTC) #2
kevmoo-old
7 years, 4 months ago (2013-08-13 18:32:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26072 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698