Issue 22966015: Revert "Make Map constructors return LinkedHashMap."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22966015: Revert "Make Map constructors return LinkedHashMap." (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Make Map constructors return LinkedHashMap." Some tests are making assumptions that are not warranted. Committed: https://code.google.com/p/dart/source/detail?r=26624

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -33 lines)			Patch
M	sdk/lib/collection/linked_hash_map.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/map.dart	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/corelib/map_from_iterable_test.dart	View	6 chunks	+7 lines, -6 lines	0 comments	Download
M	tests/corelib/map_from_iterables_test.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/corelib/map_from_test.dart	View	4 chunks	+4 lines, -17 lines	0 comments	Download
M	tests/corelib/map_values2_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

Committed patchset #1 manually as r26624 (presubmit successful).

7 years, 3 months ago (2013-08-26 09:13:03 UTC) #2

Message was sent while issue was closed.

LGTM. :(