Issue 22961004: Hide methods marked as not-visible from reflective member lists and invocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22961004: Hide methods marked as not-visible from reflective member lists and invocation. (Closed)

Created:
7 years, 4 months ago by rmacnak

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, Michael Lippautz (Google), ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Hide methods marked as not-visible from reflective member lists and invocation. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26093

Patch Set 2 : avoid continue #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -10 lines)			Patch
	M	runtime/lib/mirrors.cc	View	1	9 chunks	+14 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/22961004/diff/3001/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/22961004/diff/3001/runtime/lib/mirrors.cc#newcode489 runtime/lib/mirrors.cc:489: if (!func.is_visible()) continue; Instead of 'continue', I would ...

7 years, 4 months ago (2013-08-13 00:41:23 UTC) #2

rmacnak

7 years, 4 months ago (2013-08-13 23:17:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26093 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22961004: Hide methods marked as not-visible from reflective member lists and invocation. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : avoid continue #

Messages