Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 22960005: Refactoring custom elements test and adding test case for mixins. (Closed)

Created:
7 years, 4 months ago by blois
Modified:
7 years, 4 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Currently the mixins case is failing on the dart2js version. The auto-tag generation makes it easier to add new tests without re-indexing or worrying about overlapping tags. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=26285

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -20 lines) Patch
M tests/html/custom_elements_test.dart View 1 2 7 chunks +52 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 4 months ago (2013-08-14 20:40:16 UTC) #1
vsm
lgtm Is this working everywhere?
7 years, 4 months ago (2013-08-16 00:15:44 UTC) #2
blois
Works on Dartium, fails on dart2js right now, but the tests are skipped there (no ...
7 years, 4 months ago (2013-08-16 00:41:26 UTC) #3
blois
7 years, 4 months ago (2013-08-16 17:38:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r26285 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698