Build shadow_dom package in dart/pkg

Build shadow_dom package in dart/pkg

BUG=
R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26231

[terry, 2013-08-13 18:12:02]

Building of shadow_dom package done from tools.  After gclient sync (which
creates lib/src/ShadowDOM), npm install then grunt will build the debug and min
js files in lib.

[Jennifer Messerly, 2013-08-13 18:14:31]

On 2013/08/13 18:12:02, terry wrote:
> Building of shadow_dom package done from tools.  After gclient sync (which
> creates lib/src/ShadowDOM), npm install then grunt will build the debug and
min
> js files in lib.

Q: shouldn't the tests come from gclient too?

[terry, 2013-08-15 19:34:08]

On 2013/08/13 18:14:31, John Messerly wrote:
> On 2013/08/13 18:12:02, terry wrote:
> > Building of shadow_dom package done from tools.  After gclient sync (which
> > creates lib/src/ShadowDOM), npm install then grunt will build the debug and
> min
> > js files in lib.
> 
> Q: shouldn't the tests come from gclient too?

Good idea - done.

[terry, 2013-08-15 19:35:00]

ShadowDOM in third_party/polymer, test pulled from ShadowDOM/test

[Jennifer Messerly, 2013-08-15 21:01:37]

I think we're missing pubspec.yaml and README.md?

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/lib/src/pla...
File pkg/shadow_dom/lib/src/platform/patches-shadow-css.js (right):

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/lib/src/pla...
pkg/shadow_dom/lib/src/platform/patches-shadow-css.js:19: var r = '', l=0,
matches;
spaces before and after equal sign?

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/lib/src/pla...
pkg/shadow_dom/lib/src/platform/patches-shadow-css.js:50:
document.head.appendChild(style);
dumb question, but is the appendChild really necessary?

I worry that adding+removing a style node to the document head could cause a lot
of style recalc. Is there a way we can avoid that (maybe append the node to an
iframe or something?)

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/lib/src/pla...
pkg/shadow_dom/lib/src/platform/patches-shadow-css.js:57: for (var i=0, css=[];
i < cssRules.length; i++) {
spaces

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/lib/src/pla...
File pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill-before.js
(right):

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/lib/src/pla...
pkg/shadow_dom/lib/src/platform/patches-shadowdom-polyfill-before.js:7: //
TODO(jmesserly): fix dart:html to use unprefixed name
I wonder if this is fixed now. I think it might be. maybe we can delete this
whole file now :)

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/tool/README.md
File pkg/shadow_dom/tool/README.md (right):

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/tool/README...
pkg/shadow_dom/tool/README.md:1: ## Learn the tech
why is this file under "tool"?

[Jennifer Messerly, 2013-08-15 21:30:44]

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/tool/README.md
File pkg/shadow_dom/tool/README.md (right):

https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/tool/README...
pkg/shadow_dom/tool/README.md:1: ## Learn the tech
On 2013/08/15 21:01:37, John Messerly wrote:
> why is this file under "tool"?

doh, I'm totally confused. The README.md already exists at root level and it has
Dart snippets. Let's keep it and remove this one :)

[terry, 2013-08-15 21:51:52]

On 2013/08/15 21:30:44, John Messerly wrote:
>
https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/tool/README.md
> File pkg/shadow_dom/tool/README.md (right):
> 
>
https://codereview.chromium.org/22951003/diff/9001/pkg/shadow_dom/tool/README...
> pkg/shadow_dom/tool/README.md:1: ## Learn the tech
> On 2013/08/15 21:01:37, John Messerly wrote:
> > why is this file under "tool"?
> 
> doh, I'm totally confused. The README.md already exists at root level and it
has
> Dart snippets. Let's keep it and remove this one :)

Already did that earlier.  It's not in tool directory.

[Jennifer Messerly, 2013-08-15 22:09:12]

lgtm

[terry, 2013-08-15 22:20:16]

Committed patchset #6 manually as r26231 (presubmit successful).

[kevmoo-old, 2013-08-15 23:26:24]

FYI

https://codereview.chromium.org/22951003/diff/31001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/22951003/diff/31001/.gitignore#newcode57
.gitignore:57: # Third party files
You may have missed https://code.google.com/p/dart/source/detail?r=26069

You can remove these ignores. Covered by third_party/.git_ignore