Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 22950008: move fancy_syntax into Dart SVN (Closed)

Created:
7 years, 4 months ago by Jennifer Messerly
Modified:
7 years, 4 months ago
Reviewers:
justinfagnani
CC:
reviews_dartlang.org
Visibility:
Public.

Description

move fancy_syntax into Dart SVN Changes after moving: deleted: AUTHORS, LICENSE, PATENTS, codereview.settings. these are redundant with the Dart repository files. pubspec.yaml: remove versions, changed homepage syntax_test.dart: add the HTML via Dart, so it can run on browser bots syntax_test.html: removed the HTML that is now added by syntax_test.dart pkg/pkg.status: skip the in-browser syntax_test on standalone VM R=justinfagnani@google.com Committed: https://code.google.com/p/dart/source/detail?r=26237

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rename to polymer_expression #

Patch Set 4 : more readme edits #

Total comments: 1

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3113 lines, -11 lines) Patch
M pkg/pkg.status View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A pkg/polymer_expressions/README.md View 1 2 3 4 1 chunk +282 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/example.dart View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/example.html View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/person.dart View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/streams/collect_key_press.html View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/streams/count_clicks.html View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/streams/mouse_move.html View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/example/streams/mouse_resize_image.html View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
A + pkg/polymer_expressions/lib/async.dart View 1 2 3 4 1 chunk +7 lines, -5 lines 0 comments Download
A pkg/polymer_expressions/lib/eval.dart View 1 2 3 4 1 chunk +613 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/expression.dart View 1 2 3 4 1 chunk +208 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/filter.dart View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/parser.dart View 1 2 3 4 1 chunk +282 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/polymer_expressions.dart View 1 2 3 4 1 chunk +109 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/src/mirrors.dart View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/tokenizer.dart View 1 2 3 4 1 chunk +300 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/lib/visitor.dart View 1 2 3 4 1 chunk +76 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/pubspec.yaml View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
A + pkg/polymer_expressions/test/all_tests.dart View 1 2 3 4 1 chunk +7 lines, -6 lines 0 comments Download
A pkg/polymer_expressions/test/eval_test.dart View 1 2 3 4 1 chunk +378 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/test/parser_test.dart View 1 2 3 4 1 chunk +199 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/test/syntax_test.dart View 1 2 3 4 1 chunk +87 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/test/syntax_test.html View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
A pkg/polymer_expressions/test/tokenizer_test.dart View 1 2 3 4 1 chunk +190 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jennifer Messerly
7 years, 4 months ago (2013-08-14 03:35:36 UTC) #1
justinfagnani
I'd like to rename this to expression syntax and move syntax.dart to expression_syntax.dart, should that ...
7 years, 4 months ago (2013-08-14 04:56:30 UTC) #2
Jennifer Messerly
PTAL. Renamed to polymer_expression. The changes are search+replace except the README.md which needed a bit ...
7 years, 4 months ago (2013-08-14 21:43:21 UTC) #3
Jennifer Messerly
ping :)
7 years, 4 months ago (2013-08-14 23:48:33 UTC) #4
justinfagnani
lgtm https://codereview.chromium.org/22950008/diff/9001/pkg/polymer_expression/lib/syntax.dart File pkg/polymer_expression/lib/syntax.dart (right): https://codereview.chromium.org/22950008/diff/9001/pkg/polymer_expression/lib/syntax.dart#newcode5 pkg/polymer_expression/lib/syntax.dart:5: library polymer_expression; rename this file to polymer_expression?
7 years, 4 months ago (2013-08-15 03:29:14 UTC) #5
Jennifer Messerly
renamed based on earlier discussion, want to take another look?
7 years, 4 months ago (2013-08-15 22:34:38 UTC) #6
justinfagnani
Still looks good. I don't really _like_ the plural name for the class, because an ...
7 years, 4 months ago (2013-08-15 22:48:47 UTC) #7
Jennifer Messerly
7 years, 4 months ago (2013-08-15 23:04:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r26237 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698