Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22947006: Add signMask getter to Float32x4 (Closed)

Created:
7 years, 4 months ago by Cutch
Modified:
7 years, 4 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 8

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -17 lines) Patch
M runtime/lib/simd128.cc View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/lib/typed_data.dart View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
runtime/vm/disassembler_x64.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 4 5 7 chunks +49 lines, -15 lines 0 comments Download
runtime/vm/flow_graph_type_propagator.cc View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 5 5 chunks +58 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 2 3 4 5 3 chunks +19 lines, -1 line 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
A tests/lib/typed_data/float32x4_sign_mask_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A tests/lib/typed_data/uint32x4_sign_mask_test.dart View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Cutch
7 years, 4 months ago (2013-08-15 18:54:34 UTC) #1
zra
ARM lgtm
7 years, 4 months ago (2013-08-15 19:52:54 UTC) #2
srdjan
lgtm https://codereview.chromium.org/22947006/diff/3001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/22947006/diff/3001/runtime/vm/flow_graph_optimizer.cc#newcode1500 runtime/vm/flow_graph_optimizer.cc:1500: } else if (getter == MethodRecognizer::kFloat32x4GetSignMask) { It ...
7 years, 4 months ago (2013-08-16 00:19:59 UTC) #3
Cutch
PTAL, added method to Uint32x4 as well. https://codereview.chromium.org/22947006/diff/3001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/22947006/diff/3001/runtime/vm/flow_graph_optimizer.cc#newcode1500 runtime/vm/flow_graph_optimizer.cc:1500: } else ...
7 years, 4 months ago (2013-08-19 17:23:22 UTC) #4
srdjan
https://codereview.chromium.org/22947006/diff/13001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/22947006/diff/13001/runtime/vm/flow_graph_optimizer.cc#newcode1580 runtime/vm/flow_graph_optimizer.cc:1580: return false; Does the compiler complain if you remove ...
7 years, 4 months ago (2013-08-19 17:30:26 UTC) #5
Cutch
Instructions merged. All comments addressed. https://codereview.chromium.org/22947006/diff/13001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/22947006/diff/13001/runtime/vm/flow_graph_optimizer.cc#newcode1580 runtime/vm/flow_graph_optimizer.cc:1580: return false; On 2013/08/19 ...
7 years, 4 months ago (2013-08-19 17:53:21 UTC) #6
srdjan
LGTM with comments https://codereview.chromium.org/22947006/diff/18001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/22947006/diff/18001/runtime/vm/intermediate_language.h#newcode5576 runtime/vm/intermediate_language.h:5576: return true; Only if kind's are ...
7 years, 4 months ago (2013-08-20 15:54:10 UTC) #7
Cutch
https://codereview.chromium.org/22947006/diff/18001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/22947006/diff/18001/runtime/vm/intermediate_language.h#newcode5576 runtime/vm/intermediate_language.h:5576: return true; On 2013/08/20 15:54:10, srdjan wrote: > Only ...
7 years, 4 months ago (2013-08-20 21:29:42 UTC) #8
Cutch
7 years, 4 months ago (2013-08-20 21:36:04 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 manually as r26394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698