Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 22941002: Remove unused imports in pub. (Closed)

Created:
7 years, 4 months ago by Bob Nystrom
Modified:
7 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unused imports in pub. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26040

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -298 lines) Patch
M sdk/lib/_internal/pub/bin/pub.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/help.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/install.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/lish.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/update.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/command/uploader.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/dart.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/directory_tree.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/error_group.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/git.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/lock_file.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/package.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/pub_package_provider.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/git.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/path.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/system_cache.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/dependency.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/directory.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/lib.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/license.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/name.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/pubspec_field.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/version.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/deploy/ignores_non_entrypoint_dart_files_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/descriptor/tar.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/dev_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_url_resolve_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/offline_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/remove_removed_transitive_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/broken_symlink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_and_update_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_branch_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_revision_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_transitive_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_twice_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_with_trailing_slash_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/different_repo_name_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/lock_version_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/require_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/cached_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/do_not_update_on_removed_constraints_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/install_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/install_transitive_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/repair_cache_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/resolve_constraints_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_compatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/unlock_if_incompatible_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_path_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_symlink_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/no_pubspec_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_path_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_symlink_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_symlink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/relative_symlink_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/switch_source_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/io_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lish/cloud_storage_upload_doesnt_redirect_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/cloud_storage_upload_provides_an_error_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lish/force_cannot_be_combined_with_dry_run_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/force_does_not_publish_if_there_are_errors_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_creation_provides_invalid_json_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_validation_has_a_warning_and_is_canceled_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/package_validation_has_an_error_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/preview_package_validation_has_a_warning_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/preview_package_validation_has_no_warnings_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/upload_form_provides_an_error_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lish/upload_form_provides_invalid_json_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/lock_file_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/utils.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_a_malformed_credentials_authenticates_again_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_a_pre_existing_credentials_does_not_authenticate_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_a_server_rejected_refresh_token_authenticates_again_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_an_expired_credentials_refreshes_and_saves_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_an_expired_credentials_without_a_refresh_token_authenticates_again_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_no_credentials_authenticates_and_saves_credentials_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/oauth2/with_server_rejected_credentials_authenticates_again_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/package_files_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_cache_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_install_and_update_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/pubspec_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/does_not_install_first_if_a_dependency_is_removed_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/does_not_install_first_if_git_url_did_not_change_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/does_not_install_first_if_locked_version_matches_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_dependency_added_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_dependency_version_changed_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_dev_dependency_changed_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_git_ref_changed_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_git_url_changed_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_no_lockfile_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_path_dependency_changed_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/installs_first_if_source_changed_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/serve/invalid_urls_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/missing_dependency_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_app_asset_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_app_lib_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_app_web_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_dependency_asset_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/serve_from_dependency_lib_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/unknown_dependency_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/serve/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/unknown_source_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_locked_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_one_locked_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_to_incompatible_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/unlock_dependers_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/unlock_if_necessary_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/update_removed_constraints_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/validator/directory_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/validator/size_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/version_solver_test.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/version_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
The most exciting patch EVER.
7 years, 4 months ago (2013-08-12 21:07:52 UTC) #1
nweiz
lgtm Did you do this all by hand, or is there a script we can ...
7 years, 4 months ago (2013-08-12 21:17:04 UTC) #2
Bob Nystrom
On 2013/08/12 21:17:04, nweiz wrote: > lgtm > > Did you do this all by ...
7 years, 4 months ago (2013-08-12 21:48:14 UTC) #3
Bob Nystrom
7 years, 4 months ago (2013-08-12 22:01:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r26040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698