Issue 22938002: Fix the stack trace when there are C++ frames in between dart frames.

Issue 22938002: Fix the stack trace when there are C++ frames in between dart frames. (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix the stack trace when there are C++ frames in between dart frames. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26044

Patch Set 4 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -36 lines)			Patch
M	runtime/vm/exceptions.cc	View	1 2 3	1 chunk	+45 lines, -36 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/corelib/error_stack_trace1_test.dart	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

https://codereview.chromium.org/22938002/diff/2001/tests/corelib/error_stack_trace1_test.dart File tests/corelib/error_stack_trace1_test.dart (right): https://codereview.chromium.org/22938002/diff/2001/tests/corelib/error_stack_trace1_test.dart#newcode32 tests/corelib/error_stack_trace1_test.dart:32: Expect.isTrue(e.stackTrace is StackTrace, Expect.isTrue(e.stackTrace.toString.contains("B.b"));

7 years, 4 months ago (2013-08-12 21:17:39 UTC) #3

siva

- Modified test case to check for patterns in the test case. - Modified status ...

7 years, 4 months ago (2013-08-12 23:46:56 UTC) #4

Ivan Posva

LGTM -ip https://codereview.chromium.org/22938002/diff/10001/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/22938002/diff/10001/runtime/vm/exceptions.cc#newcode252 runtime/vm/exceptions.cc:252: if (!builder->FullStacktrace()) { Move inside the if. ...

7 years, 4 months ago (2013-08-13 00:04:25 UTC) #5

siva

https://codereview.chromium.org/22938002/diff/10001/runtime/vm/exceptions.cc File runtime/vm/exceptions.cc (right): https://codereview.chromium.org/22938002/diff/10001/runtime/vm/exceptions.cc#newcode252 runtime/vm/exceptions.cc:252: if (!builder->FullStacktrace()) { On 2013/08/13 00:04:25, Ivan Posva wrote: ...

7 years, 4 months ago (2013-08-13 00:16:02 UTC) #6

siva

7 years, 4 months ago (2013-08-13 00:16:19 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 manually as r26044 (presubmit successful).

Expand Messages | Collapse Messages