Issue 22937006: Formatter token emission baby-steps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22937006: Formatter token emission baby-steps. (Closed)

Created:
7 years, 4 months ago by pquitslund

Modified:
7 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Formatter token emission baby-steps. Still playing around with emitToken(..) as a general strategy. Next step will likely be to migrate all appropriate print(..) calls to it. (Along the way a great rename will happen too.) R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=26064

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -20 lines)			Patch
	M	pkg/analyzer_experimental/lib/src/services/formatter_impl.dart	View	1 2	12 chunks	+36 lines, -20 lines	0 comments	Download
	M	pkg/analyzer_experimental/test/services/formatter_test.dart	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pquitslund

7 years, 4 months ago (2013-08-13 17:06:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r26064 (presubmit successful).

Expand Messages | Collapse Messages