Issue 22933003: Removing overloaded operations in dart2js.

Issue 22933003: Removing overloaded operations in dart2js. (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 4 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing overloaded operations in dart2js. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=26041

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -641 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		36 chunks	+0 lines, -534 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View		3 chunks	+0 lines, -48 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View		2 chunks	+0 lines, -24 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View		2 chunks	+0 lines, -35 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1	4 chunks	+25 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/idlnode.py	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

LGTM, suggest using some less generic names. Thanks! https://chromiumcodereview.appspot.com/22933003/diff/3001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://chromiumcodereview.appspot.com/22933003/diff/3001/tools/dom/scripts/htmldartgenerator.py#newcode137 tools/dom/scripts/htmldartgenerator.py:137: def ...

7 years, 4 months ago (2013-08-12 21:31:29 UTC) #2

blois

Committed patchset #2 manually as r26041 (presubmit successful).

7 years, 4 months ago (2013-08-12 22:23:52 UTC) #3

blois

7 years, 4 months ago (2013-08-13 00:22:15 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/22933003/diff/3001/tools/dom/scripts/htmldart...
File tools/dom/scripts/htmldartgenerator.py (right):

https://codereview.chromium.org/22933003/diff/3001/tools/dom/scripts/htmldart...
tools/dom/scripts/htmldartgenerator.py:137: def _FilterOverloads(self,
operationsByName, interface):
On 2013/08/12 21:31:29, sra1 wrote:
> '_RemoveShadowingOperationsWithSameSignature'

Done.

https://codereview.chromium.org/22933003/diff/3001/tools/dom/scripts/idlnode.py
File tools/dom/scripts/idlnode.py (right):

https://codereview.chromium.org/22933003/diff/3001/tools/dom/scripts/idlnode....
tools/dom/scripts/idlnode.py:499: def ComparableTo(self, operation):
On 2013/08/12 21:31:29, sra1 wrote:
> 'SameSignatureAs' would be a better name.

Done.

Expand Messages | Collapse Messages