Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 22927016: Remove the LineTransformer from dart:io (Closed)

Created:
7 years, 4 months ago by Søren Gjesse
Modified:
7 years, 4 months ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the LineTransformer from dart:io The LineTransformer has been retired, and is replaced with LineSplitter from dart:convert R=floitsch@google.com, nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26419

Patch Set 1 #

Patch Set 2 : Updated one status file #

Patch Set 3 : Changed one status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -50 lines) Patch
M pkg/analyzer_experimental/bin/analyzer.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/scheduled_test/lib/scheduled_process.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/string_transformer.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/lib/analyzer/analyze_tests.status View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/standalone/coverage_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 4 chunks +10 lines, -8 lines 0 comments Download
M tests/standalone/io/process_stdin_transform_unsubscribe_script.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_client.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M tests/standalone/io/string_transformer_test.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -1 line 0 comments Download
tests/standalone/vmservice/test_helper.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/coverage.dart View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 4 months ago (2013-08-20 14:41:49 UTC) #1
floitsch
LGTM.
7 years, 4 months ago (2013-08-20 14:44:25 UTC) #2
nweiz
pkg changes lgtm
7 years, 4 months ago (2013-08-20 19:11:21 UTC) #3
Søren Gjesse
7 years, 4 months ago (2013-08-21 07:36:06 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r26419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698